Outline button hover color (#25339)

twbs · Jan 17, 2018 · a0936c3 · a0936c3
1 parent b1a7548
commit a0936c3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/scss/_buttons.scss b/scss/_buttons.scss
@@ -68,11 +68,7 @@ fieldset:disabled a.btn {
 
 @each $color, $value in $theme-colors {
   .btn-outline-#{$color} {
-    @if $color == "light" {
-      @include button-outline-variant($value, $gray-900);
-    } @else {
-      @include button-outline-variant($value, $white);
-    }
+    @include button-outline-variant($value);
   }
 }
 

diff --git a/scss/mixins/_buttons.scss b/scss/mixins/_buttons.scss
@@ -54,14 +54,14 @@
   }
 }
 
-@mixin button-outline-variant($color, $color-hover: #fff, $active-background: $color, $active-border: $color) {
+@mixin button-outline-variant($color, $color-hover: color-yiq($color), $active-background: $color, $active-border: $color) {
   color: $color;
   background-color: transparent;
   background-image: none;
   border-color: $color;
 
   &:hover {
-    color: color-yiq($color);
+    color: $color-hover;
     background-color: $active-background;
     border-color: $active-border;
   }