Skip to content

Commit

Permalink
rm visibility where redundant to display
Browse files Browse the repository at this point in the history 
Refs #15755
  • Loading branch information
@cvrebert
cvrebert committed Mar 9, 2015
1 parent 38fbd8f commit b6b0fe7
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 6 deletions.
3 changes: 1 addition & 2 deletions less/component-animations.less
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,8 @@

.collapse {
display: none;
visibility: hidden;

This comment has been minimized.

Sign in to view

Copy link
@albertliao

albertliao Mar 18, 2015

The removal of the visibility flags from line 20 and 22 in 3.3.4, is breaking my collapsing submenu. It would still show the elements inside, even when it was suppose to be collapsed. Reverting back to 3.3.3 fixed it. FYI, I am using the Sass version.

Here's a code snippet in case it helps.

        <ul class="mainNavigation collapse navbar-collapse" collapse="navCollapsed" ng-class="!navCollapsed && 'in'">
            <li><a href="{{header.L1nav.0.url}}">{{header.L1nav.0.nav_text}}<span   class="fa fa-angle-right  visible-xs"></span></a></li>
            <li ><a href="{{header.L1nav.1.url}}">{{header.L1nav.1.nav_text}}<span   class="fa fa-angle-right  visible-xs"></span></a></li>

            <li ng-class="{selected:isCollapsed2}">
                <a href="#" ng-click="isCollapsed2 = !isCollapsed2;isCollapsed1=false;">{{header.L1nav.2.nav_text}}<span class="caret hidden-xs"></span>
                    <span   class="fa fa-angle-right visible-xs" ng-class="{'fa-angle-down':isCollapsed2}" ></span></a>
                <ul class="subnavigation visible-xs" collapse="!isCollapsed2">
                    {{#each header.L1nav.2.subNavItem}}
                    <li><a href="{{this.url}}">{{this.text}}<span class="fa fa-angle-right visible-xs"></span></a></li>
                    {{/each}}
                </ul>
            </li>
            <li ng-class="{selected:isCollapsed1}">
                <a href="#" ng-click="isCollapsed1 = !isCollapsed1;isCollapsed2=false;">{{header.L1nav.3.nav_text}}<span class="caret hidden-xs"></span>
                    <span   class="fa fa-angle-right  visible-xs"  ng-class="{'fa-angle-down':isCollapsed1}"></span></a>
                <ul class="subnavigation visible-xs" collapse="!isCollapsed1">
                    {{#each header.L1nav.3.subNavItem}}
                    <li><a href="{{this.url}}">{{this.text}}<span class="fa fa-angle-right visible-xs"></span></a></li>
                    {{/each}}
                </ul>
            </li>
        </ul>

This comment has been minimized.

Sign in to view

Copy link
@patrickhlauke

patrickhlauke Mar 18, 2015

Member

I'm guessing that you're overriding the display:none somehow, then...because once something's display:none'd, any change to visibility should have no effect. Please provide a live working example (ideally, as a separate issue, please)

This comment has been minimized.

Sign in to view

Copy link
@cvrebert

cvrebert Mar 18, 2015

Author Collaborator

@albertliao Please file a bug and include an Angular-free example of the problem using JS Bin.
Commit comments aren't the right venue for bug reports. Thanks!

&.in { display: block; visibility: visible; }
&.in { display: block; }
tr&.in { display: table-row; }
tbody&.in { display: table-row-group; }
}
Expand Down
1 change: 0 additions & 1 deletion less/navbar.less
View file
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@

&.collapse {
display: block !important;
visibility: visible !important;
height: auto !important;
padding-bottom: 0; // Override default setting
overflow: visible !important;
Expand Down
2 changes: 0 additions & 2 deletions less/navs.less
View file
Original file line number Diff line number Diff line change
Expand Up @@ -223,11 +223,9 @@
.tab-content {
> .tab-pane {
display: none;
visibility: hidden;
}
> .active {
display: block;
visibility: visible;
}
}

Expand Down
1 change: 0 additions & 1 deletion less/tooltip.less
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
position: absolute;
z-index: @zindex-tooltip;
display: block;
visibility: visible;
// Reset font and text properties given new insertion method
font-family: @font-family-base;
font-size: @font-size-small;
Expand Down

0 comments on commit b6b0fe7

Please sign in to comment.