remove reflow which do not add anything

twbs · Feb 24, 2019 · b8a7647 · b8a7647
1 parent c738b5f
commit b8a7647
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 23 deletions.
diff --git a/js/src/carousel.js b/js/src/carousel.js
@@ -13,7 +13,6 @@ import {
   getTransitionDurationFromElement,
   isVisible,
   makeArray,
-  reflow,
   triggerTransitionEnd,
   typeCheckConfig
 } from './util/index'
@@ -468,8 +467,6 @@ class Carousel {
     this._setActiveIndicatorElement(nextElement)
 
     if (this._element.classList.contains(ClassName.SLIDE)) {
-      reflow(nextElement)
-
       nextElement.classList.add(orderClassName)
       activeElement.classList.add(directionalClassName)
       nextElement.classList.add(directionalClassName)

diff --git a/js/src/collapse.js b/js/src/collapse.js
@@ -13,7 +13,6 @@ import {
   getTransitionDurationFromElement,
   isElement,
   makeArray,
-  reflow,
   typeCheckConfig
 } from './util/index'
 import Data from './dom/data'
@@ -234,8 +233,6 @@ class Collapse {
 
     this._element.style[dimension] = `${this._element.getBoundingClientRect()[dimension]}px`
 
-    reflow(this._element)
-
     this._element.classList.add(ClassName.COLLAPSING)
     this._element.classList.remove(ClassName.COLLAPSE)
     this._element.classList.remove(ClassName.SHOW)

diff --git a/js/src/modal.js b/js/src/modal.js
@@ -13,7 +13,6 @@ import {
   getTransitionDurationFromElement,
   isVisible,
   makeArray,
-  reflow,
   typeCheckConfig
 } from './util/index'
 import Data from './dom/data'
@@ -261,10 +260,6 @@ class Modal {
       this._element.scrollTop = 0
     }
 
-    if (transition) {
-      reflow(this._element)
-    }
-
     this._element.classList.add(ClassName.SHOW)
 
     if (this._config.focus) {
@@ -373,10 +368,6 @@ class Modal {
         }
       })
 
-      if (animate) {
-        reflow(this._backdrop)
-      }
-
       this._backdrop.classList.add(ClassName.SHOW)
 
       if (!callback) {

diff --git a/js/src/tab.js b/js/src/tab.js
@@ -11,8 +11,7 @@ import {
   emulateTransitionEnd,
   getSelectorFromElement,
   getTransitionDurationFromElement,
-  makeArray,
-  reflow
+  makeArray
 } from './util/index'
 import Data from './dom/data'
 import EventHandler from './dom/eventHandler'
@@ -191,8 +190,6 @@ class Tab {
       element.setAttribute('aria-selected', true)
     }
 
-    reflow(element)
-
     if (element.classList.contains(ClassName.FADE)) {
       element.classList.add(ClassName.SHOW)
     }

diff --git a/js/src/util/index.js b/js/src/util/index.js
@@ -157,8 +157,6 @@ const findShadowRoot = (element) => {
 // eslint-disable-next-line no-empty-function
 const noop = () => function () {}
 
-const reflow = (element) => element.offsetHeight
-
 export {
   jQuery,
   TRANSITION_END,
@@ -172,6 +170,5 @@ export {
   makeArray,
   isVisible,
   findShadowRoot,
-  noop,
-  reflow
+  noop
 }