Dropdown.js: Use a better selector to avoid foreign not shown instanc…

…es iteration
twbs · Dec 13, 2021 · bf168f0 · bf168f0
1 parent dcdf327
commit bf168f0
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/js/src/dropdown.js b/js/src/dropdown.js
@@ -50,6 +50,7 @@ const CLASS_NAME_DROPEND = 'dropend'
 const CLASS_NAME_DROPSTART = 'dropstart'
 
 const SELECTOR_DATA_TOGGLE = '[data-bs-toggle="dropdown"]:not(.disabled):not(:disabled)'
+const SELECTOR_DATA_TOGGLE_SHOWN = `${SELECTOR_DATA_TOGGLE}.${CLASS_NAME_SHOW}`
 const SELECTOR_MENU = '.dropdown-menu'
 const SELECTOR_NAVBAR = '.navbar'
 const SELECTOR_NAVBAR_NAV = '.navbar-nav'
@@ -340,18 +341,14 @@ class Dropdown extends BaseComponent {
       return
     }
 
-    const toggles = SelectorEngine.find(SELECTOR_DATA_TOGGLE)
+    const toggles = SelectorEngine.find(SELECTOR_DATA_TOGGLE_SHOWN)
 
     for (const toggle of toggles) {
       const context = Dropdown.getInstance(toggle)
       if (!context || context._config.autoClose === false) {
         continue
       }
 
-      if (!context._isShown()) {
-        continue
-      }
-
       const relatedTarget = {
         relatedTarget: context._element
       }