Skip to content

Commit

Permalink
Remove polyfills.
Browse files Browse the repository at this point in the history
  • Loading branch information
XhmikosR committed Nov 3, 2020
1 parent c4177c0 commit d380944
Show file tree
Hide file tree
Showing 15 changed files with 3 additions and 96 deletions.
7 changes: 1 addition & 6 deletions build/build-plugins.js
Expand Up @@ -26,7 +26,6 @@ const bsPlugins = {
Data: path.resolve(__dirname, '../js/src/dom/data.js'),
EventHandler: path.resolve(__dirname, '../js/src/dom/event-handler.js'),
Manipulator: path.resolve(__dirname, '../js/src/dom/manipulator.js'),
Polyfill: path.resolve(__dirname, '../js/src/dom/polyfill.js'),
SelectorEngine: path.resolve(__dirname, '../js/src/dom/selector-engine.js'),
Alert: path.resolve(__dirname, '../js/src/alert.js'),
Button: path.resolve(__dirname, '../js/src/button.js'),
Expand Down Expand Up @@ -66,10 +65,7 @@ const getConfigByPluginKey = pluginKey => {
pluginKey === 'Sanitizer'
) {
return {
external: [bsPlugins.Polyfill],
globals: {
[bsPlugins.Polyfill]: 'Polyfill'
}
external: []
}
}

Expand Down Expand Up @@ -138,7 +134,6 @@ const domObjects = [
'Data',
'EventHandler',
'Manipulator',
'Polyfill',
'SelectorEngine'
]

Expand Down
65 changes: 0 additions & 65 deletions js/src/dom/polyfill.js

This file was deleted.

6 changes: 2 additions & 4 deletions js/src/dom/selector-engine.js
Expand Up @@ -5,8 +5,6 @@
* --------------------------------------------------------------------------
*/

import { find as findFn, findOne } from './polyfill'

/**
* ------------------------------------------------------------------------
* Constants
Expand All @@ -21,11 +19,11 @@ const SelectorEngine = {
},

find(selector, element = document.documentElement) {
return [].concat(...findFn.call(element, selector))
return [].concat(...Element.prototype.querySelectorAll.call(element, selector))
},

findOne(selector, element = document.documentElement) {
return findOne.call(element, selector)
return Element.prototype.querySelector.call(element, selector)
},

children(element, selector) {
Expand Down
10 changes: 0 additions & 10 deletions js/tests/karma.conf.js
Expand Up @@ -137,16 +137,6 @@ if (browserStack) {
branches: 89,
functions: 90,
lines: 90
},
each: {
overrides: {
'js/src/dom/polyfill.js': {
statements: 30,
lines: 30,
branches: 8,
functions: 30
}
}
}
}
}
Expand Down
1 change: 0 additions & 1 deletion js/tests/visual/alert.html
Expand Up @@ -51,7 +51,6 @@ <h1>Alert <small>Bootstrap Visual Test</small></h1>
</div>
</div>

<script src="../../dist/dom/polyfill.js"></script>
<script src="../../dist/dom/event-handler.js"></script>
<script src="../../dist/dom/selector-engine.js"></script>
<script src="../../dist/dom/data.js"></script>
Expand Down
1 change: 0 additions & 1 deletion js/tests/visual/button.html
Expand Up @@ -44,7 +44,6 @@ <h1>Button <small>Bootstrap Visual Test</small></h1>
</div>
</div>

<script src="../../dist/dom/polyfill.js"></script>
<script src="../../dist/dom/event-handler.js"></script>
<script src="../../dist/dom/selector-engine.js"></script>
<script src="../../dist/dom/data.js"></script>
Expand Down
1 change: 0 additions & 1 deletion js/tests/visual/carousel.html
Expand Up @@ -45,7 +45,6 @@ <h1>Carousel <small>Bootstrap Visual Test</small></h1>
</div>
</div>

<script src="../../dist/dom/polyfill.js"></script>
<script src="../../dist/dom/event-handler.js"></script>
<script src="../../dist/dom/selector-engine.js"></script>
<script src="../../dist/dom/manipulator.js"></script>
Expand Down
1 change: 0 additions & 1 deletion js/tests/visual/collapse.html
Expand Up @@ -71,7 +71,6 @@ <h5 class="mb-0">
</div>
</div>

<script src="../../dist/dom/polyfill.js"></script>
<script src="../../dist/dom/event-handler.js"></script>
<script src="../../dist/dom/selector-engine.js"></script>
<script src="../../dist/dom/manipulator.js"></script>
Expand Down
1 change: 0 additions & 1 deletion js/tests/visual/dropdown.html
Expand Up @@ -210,7 +210,6 @@ <h1>Dropdown <small>Bootstrap Visual Test</small></h1>
</div>

<script src="../../../node_modules/popper.js/dist/umd/popper.min.js"></script>
<script src="../../dist/dom/polyfill.js"></script>
<script src="../../dist/dom/event-handler.js"></script>
<script src="../../dist/dom/selector-engine.js"></script>
<script src="../../dist/dom/data.js"></script>
Expand Down
1 change: 0 additions & 1 deletion js/tests/visual/modal.html
Expand Up @@ -206,7 +206,6 @@ <h4 class="modal-title" id="slowModalLabel">Lorem slowly</h4>
</div>

<script src="../../../node_modules/popper.js/dist/umd/popper.min.js"></script>
<script src="../../dist/dom/polyfill.js"></script>
<script src="../../dist/dom/event-handler.js"></script>
<script src="../../dist/dom/selector-engine.js"></script>
<script src="../../dist/dom/data.js"></script>
Expand Down
1 change: 0 additions & 1 deletion js/tests/visual/popover.html
Expand Up @@ -32,7 +32,6 @@ <h1>Popover <small>Bootstrap Visual Test</small></h1>
</div>

<script src="../../../node_modules/popper.js/dist/umd/popper.min.js"></script>
<script src="../../dist/dom/polyfill.js"></script>
<script src="../../dist/dom/event-handler.js"></script>
<script src="../../dist/dom/selector-engine.js"></script>
<script src="../../dist/dom/manipulator.js"></script>
Expand Down
1 change: 0 additions & 1 deletion js/tests/visual/scrollspy.html
Expand Up @@ -86,7 +86,6 @@ <h2 id="final">Final section</h2>
<p>Ad leggings keytar, brunch id art party dolor labore.</p>
</div>

<script src="../../dist/dom/polyfill.js"></script>
<script src="../../dist/dom/data.js"></script>
<script src="../../dist/dom/event-handler.js"></script>
<script src="../../dist/dom/selector-engine.js"></script>
Expand Down
1 change: 0 additions & 1 deletion js/tests/visual/tab.html
Expand Up @@ -222,7 +222,6 @@ <h4>Tabs with list-group (with fade)</h4>
</div>

<script src="../../../node_modules/popper.js/dist/umd/popper.min.js"></script>
<script src="../../dist/dom/polyfill.js"></script>
<script src="../../dist/dom/event-handler.js"></script>
<script src="../../dist/dom/selector-engine.js"></script>
<script src="../../dist/dom/data.js"></script>
Expand Down
1 change: 0 additions & 1 deletion js/tests/visual/toast.html
Expand Up @@ -52,7 +52,6 @@ <h1>Toast <small>Bootstrap Visual Test</small></h1>
</div>
</div>

<script src="../../dist/dom/polyfill.js"></script>
<script src="../../dist/dom/event-handler.js"></script>
<script src="../../dist/dom/manipulator.js"></script>
<script src="../../dist/dom/data.js"></script>
Expand Down
1 change: 0 additions & 1 deletion js/tests/visual/tooltip.html
Expand Up @@ -70,7 +70,6 @@ <h1>Tooltip <small>Bootstrap Visual Test</small></h1>
</div>

<script src="../../../node_modules/popper.js/dist/umd/popper.min.js"></script>
<script src="../../dist/dom/polyfill.js"></script>
<script src="../../dist/dom/selector-engine.js"></script>
<script src="../../dist/dom/event-handler.js"></script>
<script src="../../dist/dom/manipulator.js"></script>
Expand Down

0 comments on commit d380944

Please sign in to comment.