Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Grunt instruction links and wording #10011

Merged
merged 1 commit into from
Aug 21, 2013
Merged

Conversation

nschonni
Copy link
Contributor

  • Replace "Requires" with "Uses" since these aren't external dependencies that are installed outside of 'npm install'
  • Add additional project links for QUnit and JSHint
  • Use placeholders for 'recess' and UglifyJS since they are linked multiple times. Also use there project pages instead of the GH repos to be consistent with links like Jekyll and Grunt earlier in the document

@cvrebert
Copy link
Collaborator

I'd prefer to retain the "Requires" phrasing. It hammers the point home.
Also, phantomjs really does need to be installed manually by the user.

@nschonni
Copy link
Contributor Author

grunt-contrib-qunit uses https://npmjs.org/package/grunt-lib-phantomjs so you don't need a host install

@nschonni
Copy link
Contributor Author

I'd get the "Requires" phrasing for stuff like grunt-contrib-sass which requires Ruby and Gems installed separately

@cvrebert
Copy link
Collaborator

Huh, guess I haven't looked that closely at the phantomjs stuff since the switch to Grunt.

cvrebert added a commit that referenced this pull request Aug 21, 2013
Update Grunt instruction links and wording
@cvrebert cvrebert merged commit 1bcf9f1 into twbs:master Aug 21, 2013
@cvrebert
Copy link
Collaborator

Alrighty then. Thanks.

@nschonni nschonni deleted the patch-1 branch August 21, 2013 22:47
@nschonni
Copy link
Contributor Author

Thanks for landing 👍
I think the npm-able PhantomJS only came along with Grunt 0.4, plus it's pretty well hidden inside there lib repos 😄

@mdo mdo mentioned this pull request Aug 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants