visible-sm visible-lg

[Seva1986]

https://dl.dropboxusercontent.com/u/37682778/error/index.html

[cvrebert]

Please state what the problem is.

[zlatanvasovic]

Problem is .visible-sm mixed with .visible-lg: it doesn't work. :(

The hell, @mdo said in #11302 that .visible-* and .hidden-* classes should be mixinable, but this is pretty painful. I must revert part of #11302.

[cvrebert]

Methinks this deserves some unit tests.

[zlatanvasovic]

Hm, CSS unit tests? Idk anything about them. xD

[mdo]

@zdroid They have to be mixin-able because they have been to date. Breaking that would break backward compatibility. Versioning sucks at times, but it can be useful as well. Feel your pain though.

[zlatanvasovic]

The problem:
.visible-sm — display: none
.visible-sm on small devices — display: block — override because of the
visible-lg !important :(
.visible-lg — display: none
.visible-g on large devices — display: block — displays on large, but
not on small ones!

2013/12/27 Mark Otto notifications@github.com

@zdroid https://github.com/ZDroid They have to be mixin-able because
they have been to date. Breaking that would break backward compatibility.
Versioning sucks at times, but it can be useful as well. Feel your pain
though.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/12015#issuecomment-31239926
.

Zlatan Vasović - ZDroid

[carasmo]

I'm using the https://github.com/twbs/bootstrap/blob/master/less/responsive-utilities.less which looks similar to https://github.com/twbs/bootstrap/blob/2b56ff04614c4617355d16c14784654e841bcf4d/less/responsive-utilities.less and .visible-sm mixed with .visible-lg: works fine.

[carasmo]

Correction: I'm using the fork only: https://github.com/ZDroid/bootstrap/commit/a21fb0bf6e47dd2b7e1fe208046391c611bc8143 -- I was importing my own theme using this fork. Works great!

[zlatanvasovic]

My first version worked well, but @mdo asked me to make utilities
mixinable, and problem came.

2013/12/29 carasmo notifications@github.com

Correction: I'm using the fork only: ZDroid@a21fb0bhttps://github.com/ZDroid/bootstrap/commit/a21fb0bf6e47dd2b7e1fe208046391c611bc8143-- I was importing my own theme using this fork. Works great!

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/12015#issuecomment-31310169
.

Zlatan Vasović - ZDroid

[carasmo]

You know, using them as mixins would never occur to me. I'm not changing your original : ZDroid@a21fb0b.

[mdo]

Rethinking this, we don't document that these classes are mixin-able. I'm fine with whatever solution we come up with that makes the most sense.

[zlatanvasovic]

@mdo My solution looks fine so far. :)

[oliholz]

Even the test cases on http://getbootstrap.com/css/#responsive-utilities-tests dosn't work currently with the 3.1.0 release.

[zlatanvasovic]

Sorry, my pull request isn't merged so far, so you can't have right
combinations. :D

You can look at
https://github.com/ZDroid/bootstrap/tree/clean-visibility-mess for more
details.

2014-01-31 oliholz notifications@github.com:

Even the test cases on
http://getbootstrap.com/css/#responsive-utilities-tests dosn't work
currently with the 3.1.0 release.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/12015#issuecomment-33792081
.

Zlatan Vasović - ZDroid

[mediastuttgart]

today updated a project from 3.0 to 3.1 - and yes, all combinations of visible-sm visible-md & co are broken. waiting for this to be fixed.

[zlatanvasovic]

Did you read my comment above?

2014-02-03 Michael Alexander Freund notifications@github.com:

today updated a project from 3.0 to 3.1 - and yes, all combinations of visible-sm
visible-md & co are broken. waiting for this to be fixed.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/12015#issuecomment-33993472
.

Zlatan Vasović - ZDroid

[glebm]

For reference, another test fiddle from twbs/bootstrap-sass#517 http://jsfiddle.net/SqQLS/

[lesterchan]

I hope this gets fixed in 3.1.1 #12492

[mediastuttgart]

@zdroid yep, waiting for something to happen :)

[zlatanvasovic]

Ok.

2014-02-04 Michael Alexander Freund notifications@github.com:

@zdroid https://github.com/ZDroid yep, waiting for something to happen
:)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/12015#issuecomment-34034651
.

Zlatan Vasović - ZDroid

[mdo]

@zdroid You have no open pull request to address this—your other PR was merged two months ago in #11302.

[mdo]

Doh, found it. My bad <3.

[zlatanvasovic]

xD

2014-02-05 Mark Otto notifications@github.com:

Doh, found it. My bad <3.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/12015#issuecomment-34132153
.

Zlatan Vasović - ZDroid