Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs do not reflect 3.1 modal change #12494

Closed
mattzuba opened this issue Feb 1, 2014 · 2 comments
Closed

Docs do not reflect 3.1 modal change #12494

mattzuba opened this issue Feb 1, 2014 · 2 comments
Labels
confirmed docs js
Milestone
v3.1.1

Comments

@mattzuba
Copy link

mattzuba commented Feb 1, 2014

The docs still state that remote content will be placed in the root modal element, not the modal-content container.
@zlatanvasovic
Copy link
Contributor

Yes, modal remote change should be documented nicely.

cvrebert added a commit that referenced this issue Feb 3, 2014
@cvrebert
update docs about destination of remote modal content; fixes #12494
76a8c76
@cvrebert
Copy link
Collaborator

cvrebert commented Feb 3, 2014

Thanks for catching this!

@mdo mdo mentioned this issue Feb 3, 2014
Closed
1 task
cvrebert added a commit that referenced this issue Feb 4, 2014
@cvrebert
fix #12494 in the migration docs
819b19e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed docs js
Projects
None yet
Milestone
v3.1.1
Development

No branches or pull requests
3 participants
@cvrebert @mattzuba @zlatanvasovic