Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.dropup should be mentioned in main Dropdown docs #15597

Closed
cvrebert opened this issue Jan 18, 2015 · 1 comment · Fixed by #15662
Closed

.dropup should be mentioned in main Dropdown docs #15597

cvrebert opened this issue Jan 18, 2015 · 1 comment · Fixed by #15662
Labels
confirmed docs
Milestone
v3.3.4

Comments

@cvrebert
Copy link
Collaborator

It's not currently mentioned in http://getbootstrap.com/components/#dropdowns but ought to be.
Right now it's only documented in the context of button groups (http://getbootstrap.com/components/#btn-dropdowns-dropup).
Refs #15142.
@cvrebert cvrebert added this to the v3.3.3 milestone Jan 18, 2015
@mdo
Copy link
Member

mdo commented Jan 18, 2015

If there's something minimal we can do, I'm fine with it, but I don't want to be duplicating more things.

kkirsche added a commit to kkirsche/bootstrap that referenced this issue Jan 23, 2015
@kkirsche
Fix issue twbs#15597 — Mention dropup variation in dropdown docs
96f904a 
Fix issue twbs#15597 — Mention dropup variation in dropdown docs
@kkirsche kkirsche mentioned this issue Jan 23, 2015
Closed
kkirsche added a commit to kkirsche/bootstrap that referenced this issue Jan 24, 2015
@kkirsche
Fix issue twbs#15597 — Mention dropup variation in dropdown docs
cb96844 
Fix issue twbs#15597 — Mention dropup variation in dropdown docs

Replace single line comment with subsection

Replace single line comment with subsection touching on the variation with an example

Fix duplicate ID's

Missed an aria label

There's already a dropdownMenu2

So many dropdown menus…
kkirsche pushed a commit to kkirsche/bootstrap that referenced this issue Jan 24, 2015
Fix issue twbs#15597 — Mention dropup variation in dropdown docs
d584e38 
Mention dropup variation in dropdown docs
Fixes twbs#15597.
kkirsche added a commit to kkirsche/bootstrap that referenced this issue Jan 24, 2015
@kkirsche
Fix issue twbs#15597 — Mention dropup variation in dropdown docs
dc50153 
Fix issue twbs#15597 — Mention dropup variation in dropdown docs

Other pull request was so messed up I sincerely have no clue how to save it. The recommended command doesn't work, can't believe rebasing is so problematic...
@kkirsche kkirsche mentioned this issue Jan 24, 2015
Merged
cvrebert added a commit that referenced this issue Feb 19, 2015
@cvrebert
Merge pull request #15662 from kkirsche/patch-5
0b10c6b 
Fix issue #15597 — Mention dropup variation in dropdown docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed docs
Projects
None yet
Milestone
v3.3.4
2 participants
@mdo @cvrebert