Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load grunt-sed via HTTPS #17445

Closed
ncksllvn opened this issue Sep 2, 2015 · 8 comments
Closed

Load grunt-sed via HTTPS #17445

ncksllvn opened this issue Sep 2, 2015 · 8 comments
Milestone

Comments

@ncksllvn
Copy link

ncksllvn commented Sep 2, 2015

Since all other dependencies are loaded via HTTPS, it makes sense to load grunt-sedthe same way even though it's being pulled from GitHub. I had some problems installing it while behind a firewall but had no problems installing any of the others.

"grunt-sed": "git+https://github.com/twbs/grunt-sed.git#v0.2.0",
@ncksllvn
Copy link
Author

ncksllvn commented Sep 2, 2015

Added pull request #17446

@cvrebert
Copy link
Collaborator

cvrebert commented Sep 2, 2015

@ncksllvn How did you determine that it's using git:// HTTP in the first place?

@cvrebert
Copy link
Collaborator

cvrebert commented Sep 2, 2015

Erm, sorry, git://, not HTTP. And I see what you mean. Looks like npm tries, in order:

  1. git://github.com/twbs/grunt-sed.git
  2. https://github.com/twbs/grunt-sed.git
  3. git@github.com:twbs/grunt-sed.git

@ncksllvn
Copy link
Author

ncksllvn commented Sep 2, 2015

@cvreber Yeah exactly. We saw this in the log file along with the ssh attempt to connect:

git clone git://github.com/twbs/grunt-sed fatal: unable to connect to github.com

@cvrebert
Copy link
Collaborator

cvrebert commented Sep 2, 2015

Filed npm/npm#9470

@TheJeremyGray
Copy link

I was having this problem too, this was perfect

@TheJeremyGray
Copy link

I think my firewall may have the git port blocked, but I had assumed it would fall back to https. I am looking into the firewall issue on my side.

@mdo mdo added this to the v3.3.6 milestone Sep 5, 2015
@mdo mdo modified the milestones: v3.3.6, v3.3.7 Nov 24, 2015
@cvrebert cvrebert removed this from the v3.3.7 milestone Nov 25, 2015
@cvrebert
Copy link
Collaborator

npm will be fixing this behavior on their end in a future release; see npm/npm#9470 (comment)

However, we do plan to kill grunt-sed for other reasons; you can track progress on that at #18338.

@cvrebert cvrebert added this to the v3.3.7 milestone Dec 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants