Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add containers which responsively switch between being fluid or fixed-width #18335

Closed
ucavus opened this issue Nov 25, 2015 · 3 comments
Closed

Comments

@ucavus
Copy link

ucavus commented Nov 25, 2015

E.g. there are no classes like container-md. I wrote a gist to work around the issue.

It seems odd that the framework allows column styles to be invoked only at certain screen widths, but not for containers (and rows).

@cvrebert cvrebert changed the title Containers are permanently forced to be either fixed or fluid Add containers which responsively switch between being fluid or fixed-width Nov 25, 2015
@mdo
Copy link
Member

mdo commented Nov 30, 2015

Containers are max-width right now, so they're always "responsive" in v4. Not sure I see much value in replacing the existing grid and container system with this—feels over engineered to me.

@ucavus
Copy link
Author

ucavus commented Nov 30, 2015

@mdo Yes, containers are already responsive but they cannot switch between fluid and fixed-width which provide very different layouts, especially on larger screens. The issue was not about making them responsive, but about allowing the same flexibility for containers as is done for columns.

@mdo
Copy link
Member

mdo commented Dec 6, 2015

I should've written that clearer—it's less about any particular behavior and more about the over-engineered aspect. The columns within those containers behave the same though—column widths are all set in percentages. A pixel-based max-width vs a width: 100% doesn't matter much.

The kind of control seems ripe just for overrides rather than a rethinking of a core part of the grid system at this point in v4's development process.

@mdo mdo closed this as completed Dec 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants