Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4 migration guide doesn't mention the removal of the .badge class #18506

Closed
vanillajonathan opened this issue Dec 9, 2015 · 4 comments
Closed

v4 migration guide doesn't mention the removal of the .badge class #18506

vanillajonathan opened this issue Dec 9, 2015 · 4 comments
Labels
confirmed docs v4
Milestone
v4.0.0-alpha.3

Comments

@vanillajonathan
Copy link
Contributor

The .badge class is removed.

There is no mention of this in the migration document.
@wolfy1339
Copy link
Contributor

New markup is .label.label-pill.label-{color}

@vanillajonathan
Copy link
Contributor Author

Oh, that is not documented in the migration document.

@wolfy1339
Copy link
Contributor

Feel free to make a PR to fix that

@cvrebert cvrebert added this to the v4.0.0-alpha.3 milestone Dec 9, 2015
@cvrebert cvrebert changed the title Badge class is removed v4 migration guide doesn't mention the removal of the .badge class Dec 9, 2015
cvrebert added a commit that referenced this issue Dec 9, 2015
@cvrebert
Add Badges entry to v4 migration guide; fixes #18506
ddba805 
[ci skip]
@cvrebert
Copy link
Collaborator

cvrebert commented Dec 9, 2015

Fixed in ddba805.

@cvrebert cvrebert closed this as completed Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed docs v4
Projects
None yet
Milestone
v4.0.0-alpha.3
Development

No branches or pull requests
3 participants
@cvrebert @wolfy1339 @vanillajonathan