Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.card-block missing clearfix #18583

Closed
aimeos opened this issue Dec 16, 2015 · 5 comments
Closed

.card-block missing clearfix #18583

aimeos opened this issue Dec 16, 2015 · 5 comments

Comments

@aimeos
Copy link

aimeos commented Dec 16, 2015

.card components that contain floats (e.g. "col-sm-6" grids) have no height because of the floating elements. Can be fixed by adding:

.card-block:after {
    display: block;
    clear: both;
    content: "";
}
@cvrebert cvrebert changed the title clear:both after floats for .card-block missing .card-block missing clearfix Dec 16, 2015
@cvrebert
Copy link
Collaborator

Erm, you're referring to clearfix, right?

@aimeos
Copy link
Author

aimeos commented Dec 16, 2015

Not the .clearfix class itself. Divs with .card-block have simply no height if they contain only floating elements like grids.

@cvrebert
Copy link
Collaborator

Not the .clearfix class itself.

I was referring to the abstract concept of clearfix. Bootstrap implements it both as a mixin and as a class though.

Divs with .card-block have simply no height if they contain only floating elements like grids.

Yes, that's what clearfix fixes. So the obvious (and seemingly reasonable) solution here would be to make .card-block include the clearfix mixin.

@aimeos
Copy link
Author

aimeos commented Dec 16, 2015

Yes, sure.

@cvrebert
Copy link
Collaborator

Fixed by #18655.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants