Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal description list lacks sufficient left-hand margin/padding #18652

Closed
patrickhlauke opened this issue Dec 23, 2015 · 4 comments
Closed

Comments

@patrickhlauke
Copy link
Member

On small screens, horizontal description lists http://v4-alpha.getbootstrap.com/content/typography/#horizontal-description are flush against the left edge of the viewport.

2015-12-23 14 34 30

@cvrebert
Copy link
Collaborator

Do we really need .dl-horizontal anymore? Seems like just using .row would be logical, and it doesn't suffer from this rendering problem.

@patrickhlauke
Copy link
Member Author

Seems like just using .row would be logical

I'd buy that for a dollar. Would it be sufficient to replace the classname in place on the existing documentation, or would that look weird (as the rest of the section on lists has special classes)? I think it would be good to document this usage of rows and cols, so completely removing this would probably be too confusing...

@bassjobsen
Copy link
Contributor

The flushing against the left edge of the viewport is due to the .dl-horizontal (or .row now) not wrapped in the required .container.

I also wonder if using grid classes in stead of .horizontal-list, .horizontal-list-item etc, ... is consistent with the bootstrap4 strategy for class naming which should make your HTML more flexible while bringing along increased extensibility. But i do understand that the ability to use grid classes for sizing is very flexible.

Using grid classes also introduces the ""problem" of having grid columns in the row taller than the next one, see the picture below:

horizontallistmeshedup

According to http://www.the-art-of-web.com/css/format-dl/ to above can be fixed when applying the CSS code beneath (clearfix variant);

dt {
  clear: left;
}    
dt::after {
  content: "";
  display: table;  
}  

@patrickhlauke
Copy link
Member Author

Closing, as the original problem with the left-hand margin/padding has been addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants