Remove print-specific img max-width:100%; style so that Google Maps etc. print correctly #19000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd other widgets print correctly See h5bp/html5-boilerplate#1741 X-Ref: #1506
mdo
added a commit
that referenced
this pull request
Jan 24, 2016
Remove print-specific img max-width:100%; style so that Google Maps etc. print correctly
Closed
|
<3 |
rdlugosz
added a commit
to rdlugosz/html5-boilerplate
that referenced
this pull request
Aug 9, 2016
Following the lead of Twitter Bootstrap (see: twbs/bootstrap#19000), remove the print media query that sets a max-width of 100% to images. This code was meant to prevent images from being cut off in print, but has a side effect of causing map tiles to disappear when printing medium-to-large maps (e.g., with Google Maps). For reference, this style was added to H5BP in h5bp@b2faa1f
roblarsen
pushed a commit
to h5bp/html5-boilerplate
that referenced
this pull request
Aug 15, 2016
Following the lead of Twitter Bootstrap (see: twbs/bootstrap#19000), remove the print media query that sets a max-width of 100% to images. This code was meant to prevent images from being cut off in print, but has a side effect of causing map tiles to disappear when printing medium-to-large maps (e.g., with Google Maps). For reference, this style was added to H5BP in b2faa1f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See h5bp/html5-boilerplate#1741
X-Ref: #1506