Drop the $small-font-size variable for the newer $font-size-sm one #20867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally -font-size was added in v3 to set the font-size of the <small> element. Now that we have newer, global type variables, we can use those instead for these kind of things. Fixes #20859
Closed
|
@mdo So this changes the way works inside an h* element. Here is the example in the docs: http://v4-alpha.getbootstrap.com/content/typography/#customizing-headings . What do you think about setting `h1, h2, h3, h4, h5, h6 > small { font-size: 80% }? I can create a pull request if you like this approach. Thanks. |
|
Oh snap, I forgot about that part. I'll revisit. |
This was referenced Oct 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally
$small-font-sizewas added in v3 to set thefont-sizeof the<small>element. Now that we have newer, global type variables, we can use those instead for these kind of things.Fixes #20859