Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse wont auto height on IE #2131

Closed
pimjansen opened this issue Feb 21, 2012 · 20 comments
Closed

Collapse wont auto height on IE #2131

pimjansen opened this issue Feb 21, 2012 · 20 comments
Assignees
Labels
Milestone

Comments

@pimjansen
Copy link

The Collapse sets the height with an inline value on IE. This causes a problem while adding dynamic content with a variable height (in my case the dynatree).

Firefox / Chrome work correct.

@ghost ghost assigned fat Mar 12, 2012
@pimjansen
Copy link
Author

Is there anyone who can reproduce this?

@rxbynerd
Copy link

What steps are required to reproduce this?

@pimjansen
Copy link
Author

I have the Collapse plugin with a few blocks. My last block contains the dynatree (http://code.google.com/p/dynatree/).

When the dynatree expands the collapse wont adjust height because the height is set to the inline element. Firefox/Chrome work the way as expected though.

Hope you can reproduce it. I think its more that it wont adjust its height with dynamic JS in IE.

@pimjansen
Copy link
Author

Any progress on this?

@ctalkington
Copy link
Contributor

your best bet is going to be to provide a working link or jsfiddle so that we can see what your running into and toy with it.the inline part is interesting but in general I don't believe BS should be responsible for fixing every 3rd party issue at the expense of a huge codebase. there will always be certain setups that have issues, we almost need a user forum for this kind of stuff.

@pimjansen
Copy link
Author

Here is the JSFiddle example: http://jsfiddle.net/cRvmh/1/

As you can see it has nothing todo with the 3th party software like Dynatree but more like the Collapse itself. If you check the last tab you see a click link. In Bootstrap 2.0.1 the content div of that tab wont resize with the dynamic content.

In Bootstrap 2.0.2 it does the same but the inside content will be put on top of the tab content. As you can see there is more broken in the collapse in IE. Also the tabs wont open correctly.

@fat
Copy link
Member

fat commented Apr 15, 2012

this this is a css issue, we'll have mark look at it, thanks!

@nexeck
Copy link

nexeck commented Apr 18, 2012

+1

Same Error seems to apply for the tabs

@pimjansen
Copy link
Author

Ok thnx. Made a quickfix in my app with JS so take your time :)

@philBrown
Copy link

This can be fixed by changing line 58 in bootstrap-collapse.js from

this.$element[dimension](this.$element[0][scroll])

to

$.support.transition && this.$element[dimension](this.$element[0][scroll])

@mdo
Copy link
Member

mdo commented Apr 24, 2012

This should be resolved—it wasn't specifically an IE bug as we saw this behavior everywhere.

@mdo mdo closed this as completed Apr 24, 2012
@pimjansen
Copy link
Author

This bug is still there?

@dansantner
Copy link

philBrown.....THANK YOU Brother!!! That was driving me nuts. Worked everywhere but IE til I applied your fix.

@mmhedison
Copy link

Really Thanks
That's the easiest solution from many others philBrown

@simonstewart
Copy link

philBrown dude, shot! Was having this issue with Bootstrap v2.0.2 & IE9. Changing that line in the bootstrap js file sorted the problem out.

@dansantner
Copy link

I did notice with latest version this wasn't a problem anymore. FWIW.

@moshen
Copy link

moshen commented Jun 26, 2012

I am still having this issue w/ 2.0.4 , this jsfiddle demonstrates what I'm doing. In IE, adding elements to the uncollapsed div are obscured.

If I'm doing something wrong, I'm all ears.

@moshen
Copy link

moshen commented Jun 28, 2012

I just noticed that this was fixed only in 2.1.0 and not in 2.0.4. Good to know. Patching my local files works.

@dansantner
Copy link

2.1? Didn't know there was a version past 2.04.

@moshen
Copy link

moshen commented Jun 29, 2012

https://github.com/twitter/bootstrap/tree/2.1.0-wip , the next release?

@twbs twbs locked and limited conversation to collaborators Jul 28, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests