Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointer disabled button #22222

Closed
Thibault34 opened this issue Mar 20, 2017 · 6 comments
Closed

Pointer disabled button #22222

Thibault34 opened this issue Mar 20, 2017 · 6 comments
Assignees
Labels

Comments

@Thibault34
Copy link

Thibault34 commented Mar 20, 2017

Hello,

When button link is disabled, curors "cursor: not-allowed;" not found.

https://v4-alpha.getbootstrap.com/components/buttons/#disabled-state

@mdo
Copy link
Member

mdo commented Mar 20, 2017

This is another problem with the pointer-events: none property. We apply that to anchor based buttons, but not the <button> elements. Any element with that doesn't get cursor changes.

/cc @patrickhlauke

@patrickhlauke
Copy link
Member

On the road, so can't dig into the code...but I'm slowly wondering if we should drop the pointer-events:none and live with the fact that if authors use anchor-based buttons, they're going to have a bad time / it's the wrong way to do it...

@patrickhlauke patrickhlauke self-assigned this Mar 21, 2017
@mdo
Copy link
Member

mdo commented Mar 21, 2017

I'm fine with that I think. We've run into that issue in a few place without buttons too though, so will want to take inventory of all that before moving forward.

Holler when you're back and ready to dig in!

@patrickhlauke
Copy link
Member

@mdo actually related to this...i've been pondering, along the same lines as the decision to remove cursor things relating to buttons and faked buttons, if there's any chance to remove the actual cursor: not-allowed instances? browsers don't normally use the "not-allowed" cursor in these circumstances, so it makes BS a bit opinionated here. (and, at least on Windows, the "not-allowed" cursor looks rather fugly with its red colour compared to other regular mouse pointers)

capture

@mdo
Copy link
Member

mdo commented Apr 10, 2017

I'm good with removing that cursor option. I think I'd rather provide no feedback (other than hover/focus states) on those actions than the not-allowed cursor.

patrickhlauke added a commit that referenced this issue Apr 10, 2017
Per discussion on #22222 (comment)

> browsers don't normally use the "not-allowed" cursor in these circumstances, so it makes BS a bit opinionated here. (and, at least on Windows, the "not-allowed" cursor looks rather fugly with its red colour compared to other regular mouse pointers)
>
> ![capture](https://cloud.githubusercontent.com/assets/895831/24841663/1f9bbd46-1d81-11e7-9e96-54502b731edf.PNG)

Closes #22222
@runderworld
Copy link

years late to the party on this one, but i think a better solution would have been to default the 3.x-era $cursor-disabled variable to null/empty, and then users can reenable as needed. I totally agreed with the reasoning behind removing the not-allowed styling as the default, but just suggesting this kind of strategy in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants