Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] form-control: Remove background-image: none; #23817

Closed
mariusa opened this issue Sep 3, 2017 · 3 comments
Closed

[v4] form-control: Remove background-image: none; #23817

mariusa opened this issue Sep 3, 2017 · 3 comments

Comments

@mariusa
Copy link
Contributor

mariusa commented Sep 3, 2017

form-control has
background-image: none;

Why is that?

On some sites there are customizations on select, which set webkit-appearance to none and add a background-image with an arrow.
Applying bootstrap removes that image, but also doesn't reset webkit-appearance (remains none), so select controls don't have a dropdown icon at all.

Would you please consider removing
background-image: none;
?

@Johann-S
Copy link
Member

Johann-S commented Sep 4, 2017

It's to reset unusual Firefox-on-Android default style see :
https://github.com/twbs/bootstrap/blob/v4-dev/scss/_forms.scss#L16 and
necolas/normalize.css#214

@Fouzyyyy
Copy link

Fouzyyyy commented Sep 4, 2017

I'm wondering if adding this detail to the documentation Form controls to make sure the twbs users are aware of this detail is a good idea.

@Herst
Copy link
Contributor

Herst commented Sep 4, 2017

The issue has been resolved in Firefox 35 (released January 2015) according to necolas/normalize.css#214 (comment).

@mdo mdo added this to Inbox in v4 Beta 3 Oct 19, 2017
@mdo mdo added the has-pr label Oct 20, 2017
mdo added a commit that referenced this issue Oct 20, 2017
As the diff shows, this was for a Firefox Android issue that's since been fixed. Closes #23817.
XhmikosR pushed a commit that referenced this issue Oct 20, 2017
As the diff shows, this was for a Firefox Android issue that's since been fixed.

Closes #23817.
XhmikosR pushed a commit that referenced this issue Oct 20, 2017
As the diff shows, this was for a Firefox Android issue that's since been fixed.

Closes #23817.
@mdo mdo moved this from Inbox to Shipped in v4 Beta 3 Oct 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4 Beta 3
  
Shipped
Development

No branches or pull requests

5 participants