Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How does preview.twbsapps.com work? #26541

Closed
MartijnCuppens opened this issue May 19, 2018 · 4 comments
Closed

How does preview.twbsapps.com work? #26541

MartijnCuppens opened this issue May 19, 2018 · 4 comments
Labels
build v4

Comments

@MartijnCuppens
Copy link
Member

This PR #20179 looks interesting, but how does it work?

cc @cvrebert
@Johann-S
Copy link
Member

IMO currently it's not used because this script is never called : https://github.com/twbs/bootstrap/blob/v4-dev/package.json#L62

@XhmikosR
Copy link
Member

We might as well remove the script if it's obsolete.

@Johann-S
Copy link
Member

Finally I found it's called here: https://github.com/twbs/bootstrap/blob/v4-dev/.travis.yml#L17

@mdo
Copy link
Member

mdo commented May 26, 2018

Let's remove it since it's unused.

@XhmikosR XhmikosR mentioned this issue May 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build v4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mdo @XhmikosR @Johann-S @MartijnCuppens and others