Allow PRs to be previewed in-browser without building them locally #20179
Conversation
|
Seems to work pretty good so 👍 from me. |
|
Maybe later, it would be interesting to allow to specifie a fork to check PRs. |
| // Skip Sauce on Travis when [skip sauce] is in the commit message | ||
| if (isUndefOrNonZero(process.env.TWBS_DO_SAUCE)) { | ||
| testSubtasks.push('connect'); | ||
| testSubtasks.push('saucelabs-qunit'); |
|
Awesome work! Looks very handy. |
|
Any interests about my comment : #20179 (comment) ? |
|
@Johann-S I don't quite understand the suggestion. This already works for PRs. |
|
Sorry I thought your PR allows us to see the result of all PR not only PR for the documentation. I would like to say how can I show the result of this PR #18847 with your tool ? |
|
@Johann-S You would need to rebase it against the current |
|
Ok ! Thank you very much 👍 |
It works for all PRs that touch the Sass, JS, or HTML, but not the build system (Gruntfile, Travis, etc.; for security reasons). Not just docs PRs. |
I still need to muck around with Savage a bit for this, but the idea is that for Sass or JS PRs, Travis can build the docs with the PR's changes and upload a copy to http://preview.twbsapps.com/c/${commit-sha}/ (and eventually we can post a GitHub comment that links to the URL). This is more convenient than having to pull down the PR locally, run Grunt, and then run Jekyll.
Also, we can eventually point Sauce/BrowserStack/etc. at these public URLs, instead of setting up a local tunnel to Travis, which can be flaky/slow sometimes.
CC: @twbs/team