Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match .table-dark background-color to the $gray-dark variable #27846

Merged
merged 2 commits into from Dec 21, 2018
Merged

Match .table-dark background-color to the $gray-dark variable #27846

merged 2 commits into from Dec 21, 2018

Conversation

mdo
Copy link
Member

@mdo mdo commented Dec 15, 2018

Turns out .table-dark is one of the only places where the "dark" variation was using $gray-900 instead of $gray-800, as declared in our color map.

Fixes #27845.

@mdo mdo requested a review from a team as a code owner December 15, 2018 18:18
@XhmikosR XhmikosR added this to Inbox in v4.2 via automation Dec 15, 2018
@mdo mdo added this to Inbox in v4.3 via automation Dec 17, 2018
@mdo mdo removed this from Inbox in v4.2 Dec 17, 2018
@mdo mdo moved this from Inbox to Ready to merge in v4.3 Dec 17, 2018
@mdo mdo merged commit 901761a into v4-dev Dec 21, 2018
v4.3 automation moved this from Ready to merge to Shipped Dec 21, 2018
@mdo mdo mentioned this pull request Dec 21, 2018
Closed
@XhmikosR XhmikosR deleted the table-dark-colors branch December 22, 2018 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
css v4
Projects
No open projects
v4.3
  
Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdo @XhmikosR