Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new .text-break utility for applying word-break: break-word #27863

Merged
merged 3 commits into from Dec 21, 2018

Conversation

mdo
Copy link
Member

@mdo mdo commented Dec 16, 2018

If we need to be changing the breaking of content, we shouldn't be doing it piece meal on our components. A utility helps in the interim, hence this PR, but v5 will likely see this added to the <body> element in Reboot to solve the problem across the entire project. (At that point we'll likely need the opposite utility, too).

Fixes #19315.

@mdo mdo added this to Inbox in v4.3 via automation Dec 16, 2018
@mdo mdo requested a review from a team as a code owner December 16, 2018 21:25
@MartijnCuppens
Copy link
Member

Looks good, maybe add some documentation?

@mdo
Copy link
Member Author

mdo commented Dec 17, 2018

@MartijnCuppens Added!

Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful!

@mdo mdo moved this from Inbox to Ready to merge in v4.3 Dec 17, 2018
@mdo mdo merged commit f7bf353 into v4-dev Dec 21, 2018
v4.3 automation moved this from Ready to merge to Shipped Dec 21, 2018
@mdo mdo mentioned this pull request Dec 21, 2018
@XhmikosR XhmikosR deleted the text-break-util branch December 22, 2018 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.3
  
Shipped
Development

Successfully merging this pull request may close these issues.

None yet

2 participants