Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent checks from shrinking in inline forms #27870

Merged
merged 2 commits into from Dec 21, 2018
Merged

Prevent checks from shrinking in inline forms #27870

merged 2 commits into from Dec 21, 2018

Conversation

mdo
Copy link
Member

@mdo mdo commented Dec 17, 2018

Fixes #25336

@mdo mdo added this to Inbox in v4.3 via automation Dec 17, 2018
@mdo mdo requested a review from a team as a code owner December 17, 2018 22:51
@MartijnCuppens
Copy link
Member

Not sure how to test this, is this a linux only issue?

@mdo
Copy link
Member Author

mdo commented Dec 18, 2018

@MartijnCuppens Not Linux only. Take any .form-check within .form-inline and give it a fixed width of like 100px.

@mdo
Copy link
Member Author

mdo commented Dec 18, 2018

To expand on that, we have styles that change the .form-check's display to flex, and the default behavior of flex children is to shrink. The only way to prevent this, other than rewriting inline forms, is to prevent the input from behaving like that.

@mdo mdo moved this from Inbox to Ready to merge in v4.3 Dec 21, 2018
@mdo mdo merged commit f6abb49 into v4-dev Dec 21, 2018
v4.3 automation moved this from Ready to merge to Shipped Dec 21, 2018
@mdo mdo deleted the stop-shrinking-inputs branch December 21, 2018 21:52
@mdo mdo mentioned this pull request Dec 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
css v4
Projects
No open projects
v4.3
  
Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mdo @MartijnCuppens @XhmikosR