Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove screen from media query #27985

Merged
merged 2 commits into from Jan 7, 2019
Merged

Remove screen from media query #27985

merged 2 commits into from Jan 7, 2019

Conversation

MartijnCuppens
Copy link
Member

We don't use screen anywhere else in our media queries and there's no reason why we should disable it if the device is not a screen.

@MartijnCuppens MartijnCuppens requested a review from a team as a code owner January 5, 2019 20:17
@XhmikosR XhmikosR added the v4 label Jan 5, 2019
andresgalante
andresgalante approved these changes Jan 7, 2019
View reviewed changes
Copy link
Collaborator

@andresgalante andresgalante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, and there is no motion on a screen reader or a paper :)

@mdo mdo added this to Inbox in v4.3 via automation Jan 7, 2019
@mdo mdo mentioned this pull request Jan 7, 2019
Closed
@XhmikosR XhmikosR moved this from Inbox to Ready to merge in v4.3 Jan 7, 2019
@XhmikosR XhmikosR merged commit 2b96e9a into v4-dev Jan 7, 2019
v4.3 automation moved this from Ready to merge to Shipped Jan 7, 2019
@XhmikosR XhmikosR deleted the v4-dev-martijncuppens-remove-screen branch January 7, 2019 16:18
MartijnCuppens added a commit that referenced this pull request Jan 12, 2019
@MartijnCuppens
remove screen from media query (#27985)
2f55969
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

@andresgalante andresgalante andresgalante approved these changes

Assignees
No one assigned
Labels
css v4
Projects
No open projects
v4.3
  
Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MartijnCuppens @mdo @andresgalante @XhmikosR