Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: use the twitter Jekyll variable everywhere #27990

Merged
merged 1 commit into from Jan 7, 2019
Merged

docs: use the twitter Jekyll variable everywhere #27990

merged 1 commit into from Jan 7, 2019

Conversation

wenzhixin
Copy link
Contributor

No description provided.

XhmikosR
XhmikosR requested changes Jan 6, 2019
View reviewed changes
Copy link
Member

@XhmikosR XhmikosR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks but there are a few more cases in getting-started/introduction.md

@wenzhixin
Copy link
Contributor Author

OK, I will update all cases.

@wenzhixin
Copy link
Contributor Author

Done

@XhmikosR
Copy link
Member

XhmikosR commented Jan 7, 2019

Thanks!

@XhmikosR XhmikosR changed the title Footer twitter link use variable instead docs: use the twitter Jekyll variable everywhere Jan 7, 2019
@XhmikosR XhmikosR merged commit 87cd64e into twbs:v4-dev Jan 7, 2019
@XhmikosR XhmikosR added this to Inbox in v4.3 via automation Jan 7, 2019
@XhmikosR XhmikosR moved this from Inbox to Shipped in v4.3 Jan 7, 2019
@mdo mdo mentioned this pull request Jan 7, 2019
Closed
MartijnCuppens pushed a commit that referenced this pull request Jan 12, 2019
@wenzhixin @MartijnCuppens
docs: use the twitter Jekyll variable everywhere (#27990)
acf1b28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XhmikosR XhmikosR XhmikosR approved these changes

Assignees
No one assigned
Labels
docs v4
Projects
No open projects
v4.3
  
Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wenzhixin @XhmikosR