Make component colors configurable #28035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartijnCuppens
commented
Jan 13, 2019
|
@MartijnCuppens Can you double check conflicts? <3 |
MartijnCuppens
force-pushed
the
v4-dev-martijncuppens-component-colors
branch
from
cf3b50f
to
3afed98
Compare
MartijnCuppens
force-pushed
the
v4-dev-martijncuppens-component-colors
branch
from
245948f
to
13a9e54
Compare
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently discovered properties aren't rendered if their value is set to
null. That's quite interesting because this allows us to make things configurable without rendering useless code.I used this technique to make it possible to change the default colors of the Bootstrap components.