Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional btn & input font family #28068

Merged
merged 2 commits into from Feb 7, 2019

Conversation

MartijnCuppens
Copy link
Member

Optional font family for .btns and .form-controls. Doesn't generate any css by default.

@MartijnCuppens MartijnCuppens requested a review from a team as a code owner January 15, 2019 22:11
@MartijnCuppens MartijnCuppens added this to Inbox in v4.3 via automation Jan 15, 2019
@mdo
Copy link
Member

mdo commented Jan 20, 2019

We'll want to check the default font stacks for some older browsers. I can't remember for certain anymore, but I feel like some weren't inheriting their fonts in inputs and buttons.

@MartijnCuppens
Copy link
Member Author

@mdo, I guess this is already fixed in reboot:

bootstrap/scss/_reboot.scss

Lines 313 to 322 in e65dccf

input,
button,
select,
optgroup,
textarea {
margin: 0; // Remove the margin in Firefox and Safari
font-family: inherit;
font-size: inherit;
line-height: inherit;
}

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well then, awesome! :shipit: 😆

@mdo mdo mentioned this pull request Feb 7, 2019
@XhmikosR XhmikosR moved this from Inbox to Ready to merge in v4.3 Feb 7, 2019
@XhmikosR XhmikosR merged commit 8b41cb1 into v4-dev Feb 7, 2019
v4.3 automation moved this from Ready to merge to Shipped Feb 7, 2019
@XhmikosR XhmikosR deleted the v4-dev-mc-optinal-input-btn-font-family branch February 7, 2019 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v4.3
  
Shipped
Development

Successfully merging this pull request may close these issues.

None yet

3 participants