-
-
Notifications
You must be signed in to change notification settings - Fork 78.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various issues with the 'btn' class when in the topbar #285
Comments
i think placing btns in the topbar is not really a recommended convention - keep items in there conventional locations. |
They are helpful when used as a call to action from within the topbar though - Login/Register/etc. |
Agreed.
|
Basically they should not be used in If you remove the divs they seem to work well. |
Resolved in 2.0-wip. |
Please see the following: http://jsfiddle.net/JpKY6/5/
When using
<a>
elements in atopbar
div, I'm encountering a number of layout and style problems. The source code above details the problems and their reproducibility, but namely:<a class="btn primary">
in thetopbar
is set to have 100% height, which doesn't look too good.<button class="btn primary">
in thetopbar
is the right vertical size, but isn't vertically aligned to the center like normal<a>
would be.<a class="btn">
in thetopbar
is similar to issue 1 above, but colors are messed up (possibly from selectors dealing with thetopbar
).The text was updated successfully, but these errors were encountered: