Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various issues with the 'btn' class when in the topbar #285

Closed
naftulikay opened this issue Sep 21, 2011 · 5 comments
Closed

Various issues with the 'btn' class when in the topbar #285

naftulikay opened this issue Sep 21, 2011 · 5 comments
Milestone

Comments

@naftulikay
Copy link

Please see the following: http://jsfiddle.net/JpKY6/5/

When using <a> elements in a topbar div, I'm encountering a number of layout and style problems. The source code above details the problems and their reproducibility, but namely:

  1. <a class="btn primary"> in the topbar is set to have 100% height, which doesn't look too good.
  2. <button class="btn primary"> in the topbar is the right vertical size, but isn't vertically aligned to the center like normal <a> would be.
  3. <a class="btn"> in the topbar is similar to issue 1 above, but colors are messed up (possibly from selectors dealing with the topbar).
@lukeholder
Copy link

i think placing btns in the topbar is not really a recommended convention - keep items in there conventional locations.

@mariozig
Copy link

mariozig commented Oct 4, 2011

They are helpful when used as a call to action from within the topbar though - Login/Register/etc.

@naftulikay
Copy link
Author

Agreed.
On Oct 3, 2011 10:24 PM, "Mario Zigliotto" <
reply@reply.github.com>
wrote:

They are helpful when used as a call to action from within the topbar
though - Login/Register/etc.

Reply to this email directly or view it on GitHub:
#285 (comment)

@icanb
Copy link

icanb commented Dec 17, 2011

Basically they should not be used in

If you remove the divs they seem to work well.

@mdo
Copy link
Member

mdo commented Dec 27, 2011

Resolved in 2.0-wip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants