put back autocomplete="off" warning and add it on all checkboxes and radio?

[Lausselloic]

I haven't find it in v4 documentation and all input checkboxes and radio doen't have the autocomplete attribute but as mentioned in v3 :
https://getbootstrap.com/docs/3.4/javascript/#callout-buttons-ff-autocomplete firefox persist state during browsing https://bugzilla.mozilla.org/show_bug.cgi?id=654072

So maybe need to add autocomplete="off" on all radio and checkboxes in V4/V5 documentation + put back the callout?

[mdo]

Inclined to leave it off—haven't seen any reported issues I think on this?

[Lausselloic]

there's no issues you're right but maybe need to make a choice? remove all autocomplete on checkboxes and labels, or put it quite everywhere with an explaination?
I've open that question because I've question myself about that attribute on a radio group in bootstrap and find the reply in v3.

But for sure it's a desired functionnality of Firefox so maybe remove all autocomplete attribute would make sense. Let you decide :-)

[ffoodd]

FWIW as a Firefox user I truly appreciate those persistent states.
I'd recommend to completely remove autocomplete on radio/checkbox groups.

[mdo]

I'm in favor of removing them all.

[patrickhlauke]

FWIW as a Firefox user I truly appreciate those persistent states.
I'd recommend to completely remove autocomplete on radio/checkbox groups.

However...do they cause issues? I've not tested, but could these lead to situations where a programmatically set CSS style (like active) is NOT present, but the underlying input/button has been autocompleted by Firefox silently when returning to the page?

[tmorehouse]

Using the back button will sometimes persist input states on Firefox. which is not always what is wanted (specifically with dynamically generated pages, and when the user cannot control the caching headers that served the page) I've had to use autocomplete="off" many times where I couldn't set caching headers to no-cache/must-revalidate/etc.

[tmorehouse]

Also, isn't is needed specifically for button styles checkboxes/radios?

[mohe2015]

In my opinion the problem is that there is no visual indication that firefox autocompleted a radio or checkbox. The text boxes are at least marked yellow. As I recently was looking for a bug in my code that didn't exist because of this I'm also voting for the autocomplete=off or at least something mentioned in the documentation.

[patrickhlauke]

trying to tackle the fundamental problem here #28952

[patrickhlauke]

Closed via #28952