Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue about #29544 backport to v4 docs #29637

Closed
PerseusTheGreat opened this issue Nov 4, 2019 · 1 comment
Closed

Issue about #29544 backport to v4 docs #29637

PerseusTheGreat opened this issue Nov 4, 2019 · 1 comment
Labels
docs v4

Comments

@PerseusTheGreat
Copy link

Hi.
Recently, you have shipped #29544 and have backported it to v4.x documentations in project v4.4.0.

In file /site/_includes/docs-navbar.html, at line 18, the expression {{ .Site.Params.icons }}/ does not generate correct href for new icons hyperlink in navigation bar of v4.x docs.
It should be {{ site.icons }}/.
So. please consider it.

To ensure, get and build my forked repo.
@PerseusTheGreat PerseusTheGreat changed the title Issue about #29544 backdrop to v4 docs Issue about #29544 backport to v4 docs Nov 4, 2019
@XhmikosR
Copy link
Member

XhmikosR commented Nov 4, 2019

Thanks, it's fixed in #29623

@XhmikosR XhmikosR closed this as completed Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs v4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@XhmikosR @PerseusTheGreat