Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This fix brokes border between card-header and list-group, it's doubled in 4.5.0. #30793

Closed
XhmikosR opened this issue May 12, 2020 · 3 comments · Fixed by #30808
Closed

This fix brokes border between card-header and list-group, it's doubled in 4.5.0. #30793

XhmikosR opened this issue May 12, 2020 · 3 comments · Fixed by #30808
Labels
css has-pr regression v4 v5
Projects
v5

Comments

@XhmikosR
Copy link
Member

This fix brokes border between card-header and list-group, it's doubled in 4.5.
See diffierence...
https://getbootstrap.com/docs/4.4/components/card/#list-groups
https://getbootstrap.com/docs/4.5/components/card/#list-groups

Originally posted by @waclaw66 in #30497 (comment)
@XhmikosR
Copy link
Member Author

XhmikosR commented May 12, 2020 •
edited

/CC @twbs/css-review

We need to check if master is affected too.

@mdo mdo added the regression label May 13, 2020
mdo added a commit that referenced this issue May 13, 2020
@mdo
Simplify list-group borders in cards
cfc230d 
Consolidates some CSS and beefs up the selector to account for inherited border styles. Fixes #30793, a regression from v4.4.1 that shipped in #30497.
@mdo mdo mentioned this issue May 13, 2020
Merged
@mdo mdo added this to Inbox in v5 via automation May 13, 2020
@mdo mdo added this to Inbox in v4.5.1 via automation May 13, 2020
@mdo
Copy link
Member

mdo commented May 13, 2020

We need to check if master is affected too.

Confirmed, PR opened.

@tveimo
Copy link

tveimo commented May 14, 2020 •
edited

I think this regression is also for a card-footer following a list-group. Adding to the patch above, this seems to work:

.card {
[...]
 > .list-group + .card-footer {
    border-top: 0;
  }
}

But I'm unsure if this is the correct fix.

@XhmikosR XhmikosR mentioned this issue May 14, 2020
Closed
@XhmikosR XhmikosR changed the title This fix brokes border between card-header and list-group, it's doubled in 4.5. This fix brokes border between card-header and list-group, it's doubled in 4.5.0. May 14, 2020
mdo added a commit that referenced this issue May 14, 2020
@mdo
Simplify list-group borders to prevent double borders in cards
9807b5a 
Consolidates some CSS and beefs up the selector to account for inherited border styles. Fixes #30793, a regression from v4.4.1 that shipped in #30497.
v5 automation moved this from Inbox to Shipped May 14, 2020
@XhmikosR XhmikosR removed this from Inbox in v4.5.1 May 15, 2020
@ffoodd ffoodd mentioned this issue Jun 9, 2020
Closed
@mdo mdo mentioned this issue Jun 15, 2020
Closed
ngyikp added a commit to ricochetuniverse/ricochet-universe that referenced this issue Mar 26, 2022
@ngyikp
Update npm dependencies (part 2)
3f253fc 
Bootstrap is not updated due to twbs/bootstrap#30793
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css has-pr regression v4 v5
Projects
No open projects
v5
  
Shipped
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify list-group borders in cards twbs/bootstrap
3 participants
@mdo @XhmikosR @tveimo