Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popper 2.x TODO #32354

Closed
3 of 4 tasks
XhmikosR opened this issue Dec 6, 2020 · 6 comments · Fixed by #32662
Closed
3 of 4 tasks

Popper 2.x TODO #32354

XhmikosR opened this issue Dec 6, 2020 · 6 comments · Fixed by #32662

Comments

@XhmikosR
Copy link
Member

XhmikosR commented Dec 6, 2020

@XhmikosR XhmikosR added this to Inbox in v5.0.0-beta2 via automation Dec 6, 2020
@XhmikosR XhmikosR moved this from Inbox to TODO in v5.0.0-beta2 Dec 6, 2020
@septatrix
Copy link
Contributor

#32365 should probably also be a part of this

@XhmikosR
Copy link
Member Author

XhmikosR commented Dec 8, 2020

Not really, unless a PR is submitted.

@septatrix
Copy link
Contributor

Okay, I will submit one if that is okay.

I also noticed that popper shows a warning in the console (at least when referencing the scripts manually and not using the minified bundle). Look inside the console of this pen when clicking the button. This is due to .dropdown-menu specifying a margin which poppler overwrites anyway. Do you want to track this here or create a new issue?

@XhmikosR
Copy link
Member Author

XhmikosR commented Dec 8, 2020

Please make a new issue about the second thing. We should find a way to fix this before the stable release :)

@XhmikosR
Copy link
Member Author

@rohit2sharma95 do we still need to cover the last TODO here?

@rohit2sharma95
Copy link
Collaborator

Yes, I see there are some missing tests. I will update the draft PR.

v5.0.0-beta3 automation moved this from TODO to Done Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.0.0-beta2
  
TODO
v5.0.0-beta3
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants