Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests for Popper V2 #32662

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Unit tests for Popper V2 #32662

merged 2 commits into from
Mar 17, 2021

Conversation

rohit2sharma95
Copy link
Collaborator

@rohit2sharma95 rohit2sharma95 commented Jan 3, 2021 •
edited
Loading

To cover the changes done in #31178

Closes #32354

@rohit2sharma95
Copy link
Collaborator Author

Okay, I thought that there may be test cases left for #32986, but that PR has the required tests. I see, all the remaining tests for #31178 has been added along with other PRs.

Let me know your thoughts @XhmikosR

@rohit2sharma95 rohit2sharma95 marked this pull request as ready for review March 16, 2021 19:21
@rohit2sharma95 rohit2sharma95 requested a review from a team as a code owner March 16, 2021 19:21
@XhmikosR XhmikosR added this to Inbox in v5.0.0-beta3 via automation Mar 17, 2021
@XhmikosR XhmikosR moved this from Inbox to Review in v5.0.0-beta3 Mar 17, 2021
mdo
mdo approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏻

v5.0.0-beta3 automation moved this from Review to Approved Mar 17, 2021
@XhmikosR XhmikosR merged commit 72ef1df into main Mar 17, 2021
v5.0.0-beta3 automation moved this from Approved to Done Mar 17, 2021
@XhmikosR XhmikosR deleted the rohit/main/popper-v2-tests branch March 17, 2021 19:25
This was referenced Jul 12, 2024
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
tests v5
Projects
No open projects
v5.0.0-beta3
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Popper 2.x TODO
3 participants
@rohit2sharma95 @mdo @XhmikosR