Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change .form-check background to $input-bg and change transitions #32793

Merged
merged 1 commit into from Jan 15, 2021
Merged

Change .form-check background to $input-bg and change transitions #32793

merged 1 commit into from Jan 15, 2021

Conversation

mdo
Copy link
Member

@mdo mdo commented Jan 14, 2021 •
edited

Changes the $form-check-bg from $body-bg to $input-bg.

Also, to avoid breaking changes, turns $form-check-transition to null, then adds a new $form-switch-transition variable.

Fixes #32367.

@mdo
Drop transition on .form-check, keep on .form-switch
2505028 
To avoid breaking changes, turns -check-transition to null, then adds a new -switch-transition variable
@mdo mdo requested a review from a team as a code owner January 14, 2021 04:12
@mdo mdo added this to Inbox in v5.0.0-beta3 via automation Jan 14, 2021
@mdo mdo changed the title Drop transition on .form-check, keep on .form-switch Change .form-check background to $input-bg and change transitions Jan 14, 2021
@mdo mdo mentioned this pull request Jan 14, 2021
Closed
ffoodd
ffoodd approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

v5.0.0-beta3 automation moved this from Inbox to Approved Jan 14, 2021
@mdo mdo added this to Inbox in v5.0.0-beta2 via automation Jan 15, 2021
@mdo mdo removed this from Approved in v5.0.0-beta3 Jan 15, 2021
@mdo mdo merged commit 987715f into main Jan 15, 2021
v5.0.0-beta2 automation moved this from Inbox to Done Jan 15, 2021
@mdo mdo deleted the form-check-switch-transition branch January 15, 2021 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffoodd ffoodd ffoodd approved these changes

Assignees
No one assigned
Labels
css no-backport-to-v4 v5
Projects
No open projects
v5.0.0-beta2
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v5] Checkbox background and transition
2 participants
@mdo @ffoodd