Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5: Dropdown trigger button "swallows" Esc keypresses when focused #33465

Closed
patrickhlauke opened this issue Mar 24, 2021 · 0 comments · Fixed by #33479
Closed

v5: Dropdown trigger button "swallows" Esc keypresses when focused #33465

patrickhlauke opened this issue Mar 24, 2021 · 0 comments · Fixed by #33479
Labels

Comments

@patrickhlauke
Copy link
Member

Split off from #23507 (comment) (which is an issue about v4).

If a modal dialog contains a dropdown, Esc is swallowed/intercepted by the dropdown trigger button even when the dropdown itself is closed.

Instead, the keypress should not be handled when the dropdown is closed, letting it bubble up to the modal.

See the demo https://codepen.io/Jarek3000/pen/LYxVJJg

  • launch the modal
  • Tab to the dropdown button so it receives focus
  • press Esc - nothing happens, as the keypress is intercepted by the modal code
@patrickhlauke patrickhlauke changed the title Dropdown trigger button "swallows" Esc keypresses when focused v5: Dropdown trigger button "swallows" Esc keypresses when focused Mar 24, 2021
GeoSot pushed a commit to alpadev/bootstrap that referenced this issue Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant