Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v5.1.0 CSS Grid: question about .g-start-0 #34399

Closed
cccabinet opened this issue Jul 2, 2021 · 0 comments · Fixed by #34572
Closed

v5.1.0 CSS Grid: question about .g-start-0 #34399

cccabinet opened this issue Jul 2, 2021 · 0 comments · Fixed by #34572
Labels
css v5
Projects
v5.1.0

Comments

@cccabinet
Copy link
Contributor

Looking at the recompiled CSS with the CSS grid enabled,
.grid .g-start-0 {
grid-column-start: 0;
}
is included.

grid-column-start: 0 is an invalid property value.
So, .g-start-0 is not needed. I think you'll need .g-start-12 instead.

cf.
https://developer.mozilla.org/en-US/docs/Web/CSS/grid-column#values
@XhmikosR XhmikosR changed the title 【v5.1.0 CSS Grid】About ”.g-start-0" v5.1.0 CSS Grid: question about .g-start-0 Jul 8, 2021
mdo added a commit that referenced this issue Jul 25, 2021
@mdo
Clean up a couple CSS Grid issues
d2bda79 
- Moves the make-cssgrid() mixin to the grid mixins stylesheet
- Updates the g-start-* classes to start at 1 instead of 0 as 0 is an invalid value (fixes #34399)
@mdo mdo added this to TODO in v5.1.0 via automation Jul 25, 2021
@mdo mdo mentioned this issue Jul 25, 2021
Merged
mdo added a commit that referenced this issue Jul 26, 2021
@mdo
Clean up a couple CSS Grid issues
1c81277 
- Moves the make-cssgrid() mixin to the grid mixins stylesheet
- Updates the g-start-* classes to start at 1 instead of 0 as 0 is an invalid value (fixes #34399)
v5.1.0 automation moved this from TODO to Done Jul 26, 2021
XhmikosR added a commit that referenced this issue Jul 26, 2021
@mdo @XhmikosR
Clean up a couple CSS Grid issues (#34572)
e208774 
- Moves the make-cssgrid() mixin to the grid mixins stylesheet
- Updates the g-start-* classes to start at 1 instead of 0 as 0 is an invalid value (fixes #34399)

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
marvin-hinkley-vortx pushed a commit to Vortx-Inc/bootstrap that referenced this issue Aug 18, 2021
@mdo @XhmikosR @marvin-hinkley-vortx
Clean up a couple CSS Grid issues (twbs#34572)
38c617c 
- Moves the make-cssgrid() mixin to the grid mixins stylesheet
- Updates the g-start-* classes to start at 1 instead of 0 as 0 is an invalid value (fixes twbs#34399)

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css v5
Projects
No open projects
v5.1.0
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up a couple CSS Grid issues twbs/bootstrap
2 participants
@GeoSot @cccabinet