Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change text-muted value and bind color to body-color #34457

Closed
Psixodelik opened this issue Jul 8, 2021 · 2 comments · Fixed by #35894 or #35857
Closed

Change text-muted value and bind color to body-color #34457

Psixodelik opened this issue Jul 8, 2021 · 2 comments · Fixed by #35894 or #35857

Comments

@Psixodelik
Copy link
Contributor

Hi

I've been doing a lot of website accessibility lately. I am very happy that Bootstrap provides a lot of possibilities for ensuring correct accessibility.

But I've been worried about the text-muted class for a long time. Right now, it is just a gray color, which has nothing to do with the default body-color.

Because of this, WCAG color contrast is only provided against a white background.

I suggest using the ready-made tint-color function and defining the text-muted color by mixing the body-color and white color.

You end up with something like this:

tint-color($body-color, 30%);

What do you think of it? If necessary, I will do a PR

@mdo mdo added this to To do in v5.2.0 via automation Feb 24, 2022
v5.2.0 automation moved this from To do to Done Feb 24, 2022
@julien-deramond
Copy link
Member

Reopening after reverted change that closed this issue.

@julien-deramond julien-deramond added this to To do in v5.3.0 via automation Jul 6, 2022
@mdo
Copy link
Member

mdo commented Oct 14, 2022

In #35857, I'm looking at replacing the $text-muted value from #666 to a new CSS variable that's responsive to color modes with --bs-secondary-color. This will effectively deprecate $text-muted and .text-muted which will then be removed in v6. Commit for that coming soon!

@mdo mdo mentioned this issue Oct 14, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v5.2.0
  
Done
v5.3.0
To do
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants