Dropdown cleanups #34458
Merged
Dropdown cleanups #34458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n element in case of not having the proper markup
…tra manipulations
XhmikosR
force-pushed
the
gs-dropwdown-cleanups
branch
from
a2f7326
to
c850427
Compare
XhmikosR
approved these changes
Jul 22, 2021
GeoSot
added a commit
that referenced
this pull request
Dec 9, 2021
…n using `escape` button | regression of #34458
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dataApiKeydownHandlerto handle specific instance, avoiding extra manipulationsaddinstead oftoggleon showisShownmethodNOTE for reviewers:
Better review it, commit by commit. It will help you with the proper message and will guide you with sanity to follow the logic