Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Card link not underlined on hover #34474

Closed
andrewpucci opened this issue Jul 10, 2021 · 0 comments · Fixed by #34475
Closed

Card link not underlined on hover #34474

andrewpucci opened this issue Jul 10, 2021 · 0 comments · Fixed by #34475
Projects
v5.1.0

Comments

@andrewpucci
Copy link
Contributor

As you can see on the sample card in the docs, hovering over an anchor with class card-link is not underlined.

In #30389, the default text-decoration for links is now to be underlined both on hover and not. For consistency's sake, it makes sense to me that card links should work the same way.

It seems to me that perhaps this class was missed in that PR.

Tested on macOS 11.4 and Firefox 89.0.2, but this should be independent of OS or browser.
andrewpucci added a commit to andrewpucci/bootstrap that referenced this issue Jul 10, 2021
@andrewpucci
Make text decoration consistent with other anchors
9220281 
Fixes twbs#34474
@andrewpucci andrewpucci mentioned this issue Jul 10, 2021
Merged
@XhmikosR XhmikosR added this to TODO in v5.1.0 via automation Jul 28, 2021
v5.1.0 automation moved this from TODO to Done Jul 28, 2021
XhmikosR added a commit that referenced this issue Jul 28, 2021
@andrewpucci @XhmikosR
Make text decoration consistent with other anchors (#34475)
fd9285b 
Fixes #34474

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
marvin-hinkley-vortx pushed a commit to Vortx-Inc/bootstrap that referenced this issue Aug 18, 2021
@andrewpucci @XhmikosR @marvin-hinkley-vortx
Make text decoration consistent with other anchors (twbs#34475)
8e24593 
Fixes twbs#34474

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
v5.1.0
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make text decoration consistent with other anchors andrewpucci/bootstrap
1 participant
@andrewpucci