Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select does not have border radius modificators for large and small variant #34852

Closed
crdo opened this issue Aug 31, 2021 · 0 comments · Fixed by #34853
Closed

Select does not have border radius modificators for large and small variant #34852

crdo opened this issue Aug 31, 2021 · 0 comments · Fixed by #34853
Labels
css has-pr v5
Projects
v5.1.2

Comments

@crdo
Copy link
Contributor

crdo commented Aug 31, 2021

Unlike other Form components (form-control), Select does not have a possibility to set border radius for small and large variant.

_form-control.scss
image

_form-select-scss
image

The issue can be reproduced on all OS and browsers.
crdo added a commit to crdo/bootstrap that referenced this issue Aug 31, 2021
@crdo
Fixes twbs#34852
9b0950f
@ffoodd ffoodd mentioned this issue Sep 1, 2021
Merged
@XhmikosR XhmikosR added this to In progress in v5.2.0 Sep 7, 2021
@mdo mdo added this to To do in v5.1.2 via automation Sep 7, 2021
@mdo mdo closed this as completed in #34853 Sep 7, 2021
v5.2.0 automation moved this from In progress to Done Sep 7, 2021
v5.1.2 automation moved this from To do to Done Sep 7, 2021
mdo added a commit that referenced this issue Sep 7, 2021
@crdo @XhmikosR @mdo
Add border-radius sizes to small and large .form-selects (#34853)
dbe0ad4 
Fixes #34852

Co-authored-by: Dominik Crha <crha@havit.cz>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Mark Otto <markd.otto@gmail.com>
@mdo mdo removed this from Done in v5.2.0 Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css has-pr v5
Projects
No open projects
v5.1.2
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add border-radius sizes to small and large .form-selects crdo/bootstrap
2 participants
@crdo @ffoodd