Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollbar: remove margin/padding properties properly #35388

Merged
merged 4 commits into from Dec 9, 2021

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Nov 22, 2021

fixes #35349

@GeoSot GeoSot added this to In progress in v5.2.0 via automation Nov 22, 2021
@GeoSot GeoSot force-pushed the gs/regression-on-scrolbar-helper-css-removal branch from 325fb36 to dd27d41 Compare November 23, 2021 00:10
@XhmikosR XhmikosR changed the title Scrollbar.js regression - remove margin/padding properties properly Fix Scrollbar regression - remove margin/padding properties properly Nov 23, 2021
@XhmikosR XhmikosR moved this from In progress to Review in progress in v5.2.0 Nov 23, 2021
@GeoSot GeoSot force-pushed the gs/regression-on-scrolbar-helper-css-removal branch from dd27d41 to 930d80d Compare November 23, 2021 23:03
@GeoSot GeoSot changed the title Fix Scrollbar regression - remove margin/padding properties properly Scrollbar - remove margin/padding properties properly Dec 2, 2021
@GeoSot GeoSot force-pushed the gs/regression-on-scrolbar-helper-css-removal branch from 42e05b0 to e68989f Compare December 9, 2021 13:12
@GeoSot GeoSot force-pushed the gs/regression-on-scrolbar-helper-css-removal branch from e68989f to 1888104 Compare December 9, 2021 13:34
v5.2.0 automation moved this from Review in progress to Reviewer approved Dec 9, 2021
@XhmikosR XhmikosR marked this pull request as ready for review December 9, 2021 13:45
@XhmikosR XhmikosR requested a review from a team as a code owner December 9, 2021 13:45
@XhmikosR XhmikosR merged commit 28a5a72 into main Dec 9, 2021
v5.2.0 automation moved this from Reviewer approved to Done Dec 9, 2021
@XhmikosR XhmikosR deleted the gs/regression-on-scrolbar-helper-css-removal branch December 9, 2021 13:49
@XhmikosR XhmikosR changed the title Scrollbar - remove margin/padding properties properly Scrollbar: remove margin/padding properties properly Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v5.2.0
  
Done
Development

Successfully merging this pull request may close these issues.

Issue with style.removeProperty at ScrollbarHelper
2 participants