-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Erroneous border-radius
inside Pagination
#36820
Comments
I'm not sure of anything but this could be caused by 154916c and the interrogation that I had at the time (see #36740 (comment)). In sassmeister there is apparently a difference between In our build, both versions are evaluated Are you able locally to make this change and to test if works on your side? diff --git a/scss/_pagination.scss b/scss/_pagination.scss
index e8e10a6d6..cf4db3c36 100644
--- a/scss/_pagination.scss
+++ b/scss/_pagination.scss
@@ -75,7 +75,7 @@
margin-left: $pagination-margin-start;
}
- @if $pagination-margin-start == (calc($pagination-border-width * -1)) {
+ @if $pagination-margin-start == ($pagination-border-width * -1) {
&:first-child {
.page-link {
@include border-start-radius(var(--#{$prefix}pagination-border-radius)); |
@julien-deramond yes, this fixes it. |
@julien-deramond Also confirming that your diff above fixes the issue. |
Prerequisites
Describe the issue
I just upgraded to v5.2 and am seeing an issue with
border-radius
being applied to Paginationpage-item
s:As a gut check, I looked at the compiled CSS on the Bootstrap v5.2 doc website, which has…
…whereas my compiled CSS has:
That makes me suspicious of this line, which was recently changed:
bootstrap/scss/_pagination.scss
Line 78 in edf9c40
This appears to be evaluating to
false
for me.Reduced test cases
I’ve tried to create a reduced test case here: https://www.sassmeister.com/gist/eeae55c689cbaba226ec9ef0d148f315 (note that this is using Dart Sass v1.32.12)
If that test case is valid, it seems as though the compiled version of Bootstrap 5.2 differs from (at least some…) consumer-compiled versions.
It makes me wonder if this is a variation between Sass compilers or versions. I’m in a Rails app, using the
sass-rails
andbootstrap
gems. I believesass-rails
is a wrapper around LibSass. I’m not sure which Sass was used to build the distributed CSS files for Bootstrap 5.2.Any help greatly appreciated! Let me know if I can provide anything else. Thanks!
What operating system(s) are you seeing the problem on?
macOS
What browser(s) are you seeing the problem on?
Chrome, Safari, Firefox
What version of Bootstrap are you using?
v5.2.0
The text was updated successfully, but these errors were encountered: