Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More consistency for CSS/Sass vars doc for components with dark variants #37034

Merged

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Aug 26, 2022

Description

This PR is a proposal to bring consistency between dropdowns, carousels and navbars docs which have all a dark variant.

Motivation & Context

This PR is a proposal to bring consistency between dropdowns, carousels and navbars docs which have all a dark variant.
Dropdowns documentation is taken as a reference being more detailed:

  • CSS variables mentioning that Customization through CSS variables can be seen on the .dropdown-menu-dark class where we override specific values without adding duplicate CSS selectors.
  • Sass variables separating the Sass variables used for the dark variant

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Related issues

N/A

Live previews

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@mdo mdo force-pushed the main-jd-improve-docs-for-css-scss-variables-for-dark-variants branch from 9c37686 to 571d6f6 Compare September 1, 2022 01:12
@mdo mdo merged commit a138bc3 into main Sep 1, 2022
@mdo mdo deleted the main-jd-improve-docs-for-css-scss-variables-for-dark-variants branch September 1, 2022 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants