New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move theme toggler to a partial #39807
Conversation
e83a677
to
b21e4ec
Compare
52fa751
to
e329f60
Compare
@@ -94,12 +94,17 @@ | |||
z-index: 1500; | |||
} | |||
|
|||
.bd-mode-toggle .bi { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I plan to move all this inline CSS to an external file and inline it after processing it through Sass. That's for later, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor modification in comment. The rest LGTM. It's a good idea to make this theme toggler a partial.
Co-authored-by: Julien Déramond <juderamond@gmail.com>
Description
Motivation & Context
Type of changes
Checklist
npm run lint
)Live previews
Related issues
TODO: