Move theme toggler to a partial #39807
Merged
+42
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
force-pushed
the
xmr/theme-toggler
branch
from
e83a677
to
b21e4ec
Compare
XhmikosR
force-pushed
the
xmr/theme-toggler
branch
2 times, most recently
from
52fa751
to
e329f60
Compare
XhmikosR
commented
Mar 20, 2024
| @@ -94,12 +94,17 @@ | |||
| z-index: 1500; | |||
| } | |||
|
|
|||
| .bd-mode-toggle .bi { | |||
There was a problem hiding this comment.
I plan to move all this inline CSS to an external file and inline it after processing it through Sass. That's for later, though.
julien-deramond
approved these changes
Mar 20, 2024
Co-authored-by: Julien Déramond <juderamond@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation & Context
Type of changes
Checklist
npm run lint)Live previews
Related issues
TODO: