Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icons turn white on active nav tabs #4523

Closed
wookets opened this issue Aug 21, 2012 · 8 comments
Closed

icons turn white on active nav tabs #4523

wookets opened this issue Aug 21, 2012 · 8 comments
Labels
Milestone

Comments

@wookets
Copy link

wookets commented Aug 21, 2012

  • Tabs (nav) are white.
  • Active tabs are also white.
  • Icons placed within the li of an active nav class use the white icon set.

Thus, white icons are being displayed on a white active tab, which obviously makes things look bad. Shades of gray from the icon still appear. For some icons, it is manageable, but for the home icon in particular it disappears leaving behind 5 gray dots and dashes which is not visually representative of a home.

@mdo
Copy link
Member

mdo commented Aug 21, 2012

Ah, word. I've changed the selectors for that to be more specific, targeting only nav tabs, pills, lists, and the inverse navbar in 2.1.1-wip.

@srutisha
Copy link

For the tab bar, this fix doesn't seem to work. Prefixing the .nav-tabs additionally with .navbar-inverse, however, does.

@spantaleev
Copy link
Contributor

Shouldn't you remove the 2 selectors that apply the white image sprite when it comes to .nav-tabs?
Isn't that what this issue is about?

@reaperhulk
Copy link

This doesn't appear to be entirely fixed in 2.1.1. If you add an icon like this then the icon continues to be white (presumably because it is within an anchor tag):

<ul class="nav nav-tabs">
  <li class="active"><a href="#some-path" data-toggle="tab">Name <i class="icon-info-sign"></i></a></li>
</ul>

As a workaround, adding this to a secondary CSS file will override the issue:

.nav-tabs > .active > a > [class^="icon-"],.nav-tabs>.active>a>[class*=" icon-"] { background-image:url("../img/glyphicons-halflings.png") !important; }

I'm not much of a CSS guy so I don't promise that's a fix you should apply to your own site.

@spantaleev
Copy link
Contributor

Yes, this didn't really fix the problem. Your CSS seems like a good way to work around it on 2.1.1

The issue is fixed in 2.1.2 by #4993

@mangandini
Copy link

I still have the same problem in 2.1.1 so it seems has not been fixed ? :/

@thezoggy
Copy link

right, thats why it was fixed in 2.1.2.

@J7mbo
Copy link

J7mbo commented Oct 28, 2012

Latest version still seems to have this issue - I had to use @reaperhulk's CSS - which worked great!

stempler pushed a commit to stempler/bootstrap that referenced this issue Apr 11, 2014
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants