-
-
Notifications
You must be signed in to change notification settings - Fork 78.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cursor pointer for labels #5742
Comments
Wait, why do we want a pointer for a label? Clicking it doesn't take you anywhere. At best it only focuses the field, which isn't what a pointer cursor is supposed to mean. And the example above has label[for], which at least restricts it to labels that do something, but the latest Bootstrap 2.2.2 just has "label", meaning that any label has a pointer cursor. The user will expect that clicking on it will do something (specifically, that it will take them somewhere), and it won't. |
Confused me as well. Should definitely go away at least for the basic text input. |
Confused here to. I can't think of a global reason labels would need to show a pointer on hover. |
I agree, this change does not make sense. Labels should not have cursor: pointer. Perhaps the OP's selector makes sense: "label[for]" could probably default to have pointer, but not just any label... |
I think not all clickable elements should have cursor:pointer, plus the effect you get by clicking on a label is barely visible. This confused me and I think will confuse users. |
There is a wrong concept around pointers, it should be used only when a button hasn't enough affordance. If you are developing an app the pointer should only appear for textual links and not for buttons or other controls. Unfortunately this culture of pointer for buttons have grown in the web, so we have almost no choice but to use it (although Google does not use it very often). The same does not apply for regular desktop applications. Clickable labels have no affordance at all, so it makes sense for the pointer. I am in favor of this move, never used label without the proper control reference (and I can't see any benefit doing so...). |
I agree that labels should only be used with for property. That's what the tag is designed for after all. But an affordance only has value when it allows the user to discover something meaning. Here the user loses nothing by not knowing that it is clickable. The fact that this is not common on the web, and browsers don't implement this by default means that a lot of users will be surprised by the pointer, perhaps expecting some kind of interaction to happen, or a tooltip to show up. Some users may even avoid clicking on it to avoid being brought to another page. |
The checkbox will be highlighted on hover, that is enough for the most common case I think. |
Okay so I think we're all in agreement. Not sure how we fix this. A pull request? |
Go ahead and open a pull request against
I say set the cursor there because they are in fact directly clickable and given the new structure of those form controls (divs around labels around inputs), it makes a lot of sense to encourage the larger clickable area without hitting the inadvertent clicks we have today in 2.x. Make sense? |
I no longer see in the code where this is set in 3.0.0. I suppose this was fixed in all the rework of labels. |
Oh snap, forgot I had removed them. Well, just did the second part to finish this out. Should be all set for v3 now. Thanks nerds! <3 |
We want a cursor when hovering a label used on a custom-file-input, because clicking it opens Choose file dialog. |
It would be good to have cursor:pointer style for labels by default.
Here is the example of the form with label to test -
http://twitter.github.com/bootstrap/examples/signin.html
There are already such styles:
button,
html input[type="button"],
input[type="reset"],
input[type="submit"] {
cursor: pointer;
-webkit-appearance: button;
}
It would be good also to have such styles by default:
label[for], select, .pointer {
cursor: pointer;
}
The text was updated successfully, but these errors were encountered: