fix dropdown event listener #7614
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes middle click in firefox and other issues see also: #7211
|
Aims to fix #7118. |
|
This prevents dropdowns on mobile from being dismissed with a tap to the area outside the dropdown menu. That part works on desktop still, yes, but this introduces another bug in mobile. |
|
mdo knows whats up |
|
is there a plan to fix this, then? i think "there is only one way to close dropdowns on mobile" is a good tradeoff for "middle-click now works in firefox" |
|
yep fixing it right now |
|
both will work |
|
Has this actually been rolled into a bootstrap release yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes middle click in firefox and other issues
see also: #7211 (comment)
this fix is currently running on https://zkillboard.com with what seems to be no issues (EVE-KILL/zKillboard@e770a68)