Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected color contrast to WCAG 2.0 AA (Accessibility Tweak) - Forms and Alerts #11432

Merged
merged 1 commit into from Nov 30, 2013
Merged

Corrected color contrast to WCAG 2.0 AA (Accessibility Tweak) - Forms and Alerts #11432

merged 1 commit into from Nov 30, 2013

Conversation

masterbee
Copy link
Contributor

  • Slight modification of contrast on Alerts and Form warnings to pass WCAG 2.0 Colour Contrast AA level
  • Included colour fixes as well on bs-callouts class bring them up to passable standard.
  • The visual changes on the default theme are very minor since the values were almost passable to start

Note: There is still the primary, warnings, brand, etc variable colour treatment, but these have a larger default theme impact since they touch almost all variations of buttons and progress bars, etc. I am willing to put in a PR for those fixes but there will have to be a some looking through the example to see if the impacts are acceptable.

Keep up the great work TWBS team. Loving version 3!

@masterbee
Copy link
Contributor Author

@mdo, @cvrebert - just chiming in to see if there are any thoughts on this PR. It is a small tweak to the hex values to bring them up to AA passing levels in WCAG 2 which should helps with the section 508 goal.

@cvrebert
Copy link
Collaborator

Aesthetics is entirely @mdo's domain. No comment from me other than don't get your hopes up since some WCAG color-related PRs have been rejected in the past for looking too ugly.

@masterbee
Copy link
Contributor Author

@cvrebert - Thanks for the chime in, and to help out @mdo's input I have attached the difference via 2 pngs.

Current Contrast (v3.0.1)

bootstrap current contrast

WCAG 2.0 AA Contrast Corrected

bootstrap wcag2 contrast aa pass

@adamnbowen
Copy link
Contributor

👍

@archonic
Copy link

👍 Awesome sauce.

mdo added a commit that referenced this pull request Nov 30, 2013
Corrected color contrast to WCAG 2.0 AA (Accessibility Tweak) - Forms and Alerts
@mdo mdo merged commit 938d40f into twbs:master Nov 30, 2013
@mdo mdo mentioned this pull request Nov 30, 2013
stempler pushed a commit to stempler/bootstrap that referenced this pull request Apr 11, 2014
Corrected color contrast to WCAG 2.0 AA (Accessibility Tweak) - Forms and Alerts
stempler pushed a commit to stempler/bootstrap that referenced this pull request Nov 4, 2014
Corrected color contrast to WCAG 2.0 AA (Accessibility Tweak) - Forms and Alerts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants